Draft
Conversation
ubdbra001
force-pushed
the
i48-add-espression-interpreter
branch
from
4229095 to
19cdfd0
Compare
ubdbra001
force-pushed
the
i48-add-espression-interpreter
branch
from
19cdfd0 to
5bda559
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #71 +/- ##
==========================================
- Coverage 90.89% 81.10% -9.80%
==========================================
Files 13 14 +1
Lines 846 995 +149
Branches 124 167 +43
==========================================
+ Hits 769 807 +38
- Misses 47 158 +111
Partials 30 30 🚀 New features to boost your workflow:
|
=== Do not change lines below ===
{
"chain": [],
"cmd": "uv lock",
"exit": 0,
"extra_inputs": [],
"inputs": [
"pyproject.toml",
"uv.lock"
],
"outputs": [
"uv.lock"
],
"pwd": "."
}
^^^ Do not change lines above ^^^
=== Do not change lines below ===
{
"chain": [],
"cmd": "uv lock",
"exit": 0,
"extra_inputs": [],
"inputs": [
"pyproject.toml",
"uv.lock"
],
"outputs": [
"uv.lock"
],
"pwd": "."
}
^^^ Do not change lines above ^^^
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's the initial attempt at adding all the parts of the expression language interpreter.
These successfully cover the full range of tests in the
bidsschematoolsexpression tests.Two things that still need addressing:
existspasses the tests but needs more work to actually work as described in the schema tools docsContext